search

HinTak / Font-Validator

Font Validator is a tool for testing fonts prior to release. This testing ensures that fonts meet Microsoft's high quality standards and perform exceptionally well on Microsoft's platform.
Other
146 stars 12 forks source link

FontValidator exits with 1 (instead of zero) on a successful run #48

Open erniemarch2 opened 5 years ago

erniemarch2 commented 5 years ago

When called from the command line (python script looping through several fonts in a folder), font validator processes the first item and returns non-zero exit status of 1, causing the python script to stop and not process the remaining items.

HinTak commented 5 years ago

You are aware that fontval itself takes multiple font arguments? As in '... -file font1.ttf -file font2.ttf ...'?

Also, if you really want to not stop on fatal errors, you do

'find /dir -type f -name "*.ttf" -exec FontValidator ... {} \;' ?

This is what I do for testing all 3500 fonts that fedora ships.

miguelsousa commented 5 years ago

You are aware that fontval itself takes multiple font arguments? As in '... -file font1.ttf -file font2.ttf ...'?

Yes, but we can't do that because the process we're running needs to call other tools on the same font.

Also, if you really want to not stop on fatal errors, you do 'find /dir -type f -name "*.ttf" -exec FontValidator ... {} ;' ?

I appreciate the suggestion, but we're not running FontValidator from the command-line, we're calling it from a Python subprocess.

HinTak commented 5 years ago

The exit status from mono when FontValidator is running outside of it seems to be correct, and it looks like a mono bug for the process of bundling mono with FontValidator. I'll file a bug upstream.

miguelsousa commented 5 years ago

@HinTak thank you 🙇

HinTak commented 4 years ago

I did file it upstream, https://github.com/mono/mono/issues/13629 , just forgotten to come back to mention it here. Feel free to ping upstream...