Hipposgrumm / armor-trims

2 stars 1 forks source link

[1.19.2] Significant fps drop near armor stands after installing this mod. #5

Closed MykolaHamster closed 1 year ago

MykolaHamster commented 1 year ago

Before installing trims 1.1.1: 2023-05-24_15 47 07 After: 2023-05-24_15 51 09

Other mods used: Rubidium-0.6.2a, Rubidium_extras-1.19.2_v1.3.2 debug.log

Hipposgrumm commented 1 year ago

Can you see if removing Rubidium Extras and then Rubidium fixes the problem? I need that info to help me pinpoint the problem.

Also who the heck needs that many armor stands unless you are trying to lag out the server or someone else?

MykolaHamster commented 1 year ago

Removing rubidium does not fix the problem. 2023-05-24_16 47 14

This number of armor stands is needed to demonstrate the problem. In my modpack, only seven armor stands are enough to lower fps to 20.

Hipposgrumm commented 1 year ago

I am not noticing any significant drop from the 30 I usually have. If you would send the modpack that is having problems I will gladly reopen the issue. 2023-05-25_17 42 29

MykolaHamster commented 1 year ago

Problem happens with some entities too, like piglin. Tested on clear forge 43.2.11 with and without trims backport.

26 piglins without trims backport: 2023-05-26_12 40 42

With: 2023-05-26_12 43 17

Can you reproduce this?

Hipposgrumm commented 1 year ago

I assume it affects any entity that wears armor (including players). I will join Hypixel with and without the mod and see the FPS difference. And I won’t run Fortnite in the background which might help.

Hipposgrumm commented 1 year ago

My check for custom model loaded the model every frame because I forgot to cache stuff.

MykolaHamster commented 1 year ago

Sadly, bug still persists in version 1.2. Same perfomance as on 1.1.1 2023-06-09_20 38 37 2023-06-09_20 40 45

Hipposgrumm commented 1 year ago

This hopefully will be fixed in a future version that I hopefully figure out how to add renderlayers dynamically and get them working.

MykolaHamster commented 1 year ago

I guess it's fixed in 1.3 2023-06-29_12 47 36

Hipposgrumm commented 1 year ago

B6E7AAB7-1AEE-4183-B133-007191334B7A