HomeSeer / Plugin-SDK

Plugin development kit for the 4th major edition of the HomeSeer platform.
https://www.nuget.org/packages/HomeSeer-PluginSDK/
GNU Affero General Public License v3.0
20 stars 4 forks source link

Permissions for Normal users to access plugin feature pages #305

Open BernoldNL opened 2 years ago

BernoldNL commented 2 years ago

Environment

HomeSeer

OS

Windows

HS Version

v4.2.13.0, 4.2.14.0

Development

PSDK Version

v1.4.2.0

Language

C#

IDE

VS2022

Dev OS

Windows

Page

Any plugin feature page

Plugin

Plugins using feature pages

Problem

I noticed that when a user with Normal User permissions can access my plugins' feature pages and modify the config. Looking for a way to block this, I found none.

This help page https://docs.homeseer.com/display/HS4/User+Permissions says that with Normal user permissions both Plugin Settings Pages and Plugin Feature Pages are up to the developer. When I test, I find that settings pages will not be available and feature pages are. Also, I can not find parameters for HomeSeerSystem.RegisterFeaturePage() (nor PageFactory.CreateSettingsPage()) to make it up to the developer.

Description

Describe the issue you are encountering. What happened? See Problem.

Screenshots

Attach screenshots showing what you are seeing after the problem happens. afbeelding

Expected Behavior

What did you expect to happen? I expected Plugin pages not to be permitted for normal users, but if it's up to the developer a permission parameter (required level: admin, normal user, or guest user) could help to leave access open to help pages for all and block access to config pages. True for feature pages and settings pages, I guess.

Steps to Reproduce

Provide steps so the HomeSeer team can reproduce the reported problem and see the same thing: See Problem.

Logs

If applicable, include log output from the plugin console and/or the HomeSeer logs. If the logs take up more than a few lines, consider attaching a file. N/A

spudwebb commented 2 years ago

Logges as HS-1715