search

Homebrew / legacy-homebrew

💀 The former home of Homebrew/homebrew (deprecated)
https://brew.sh
26.98k stars 11.35k forks source link

SDCC HEAD install failing #49823

Closed lieuwex closed 8 years ago

lieuwex commented 8 years ago

The patch that is applied when installing SDCC from HEAD seems broken:

$ brew install sdcc --HEAD
==> Cloning https://sdcc.svn.sourceforge.net/svnroot/sdcc/trunk/sdcc/
Updating /Library/Caches/Homebrew/sdcc--svn-HEAD
==> Downloading https://gist.githubusercontent.com/anonymous/5042275/raw/a2e084f29cd4ad9cd95e38683209991b7ac038d3/sdcc-huge-stack-auto.diff
Already downloaded: /Library/Caches/Homebrew/sdcc--patch-4fa5bf4d3f8f57682246918a06eb780e163b7207dc2cad4133d4017ae892bf6a.diff
==> Patching
==> Applying sdcc-huge-stack-auto.diff
patching file device/lib/Makefile.in
Hunk #1 FAILED at 182.
1 out of 1 hunk FAILED -- saving rejects to file device/lib/Makefile.in.rej
patching file device/lib/incl.mk
Hunk #1 succeeded at 102 (offset 7 lines).
Error: Failure while executing: /usr/bin/patch -g 0 -f -p1 -i /private/tmp/sdcc--patch20160306-78503-4w21iw/sdcc-huge-stack-auto.diff

brew gist-logs tells me there are no logs.

$ brew gist-logs sdcc
Error: No logs.

$ brew gist-logs sdcc --HEAD
Error: No logs.

SDCC installs fine when I remove the patch

dunn commented 8 years ago

Can you check if the patch has been accepted upstream? If so, we can restrict it to stable builds.

lieuwex commented 8 years ago

Looking at the Makefile.in the patch doesn't seem to be accepted upstream, but the code has been changed. I have no idea if the patch is still needed since I don't have a mcs51, but it looks like the patch has to be updated.

UniqMartin commented 8 years ago

Not sure if this is still an issue, but if it is and you are eager to continue to run the HEAD version, please consider researching whether this patch is still needed, if it is, update it, and finally contribute it back to homebrew/core. We rely on contributions from the community and cannot provide this level of support for HEAD versions that are a moving target. Thanks! Closing as there's nothing actionable here.