Hongyi6328 / pe

0 stars 0 forks source link

User can directly edit the tutorial group of a student. #10

Open Hongyi6328 opened 2 years ago

Hongyi6328 commented 2 years ago

image.png

Then the enroll, expel commands seem meaningless. Also, the user can change the tutorial group to be a non-existing group.

student edit 1 n/James Hoh p/98765432 e/a@gmail.com g/T99 t/yearTwo

nus-pe-bot commented 2 years ago

Team's Response

Same issue with #5386: allowing student to be enrolled to non-existing tutorial group

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Students that are assigned to some tutorial groups that don't exist cannot be expelled

Student 1 is assigned to tutorial group T01 which doesn't exist and he can't be expelled from it. Screenshot 2022-11-11 at 4.37.15 PM.png


[original: nus-cs2103-AY2223S1/pe-interim#5194] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

also because of the same reason. this wrong version jar file (1.3) dosent check the tutorial group's existence when enrolling. fixed in 1.4

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: The main issue of my bug is not that students can be enrolled to non-existing tutorial group. What I meant is more of a feature flaw - if you allow users to directly edit the tutorial group (yes, this tutorial group can be non-existing, too, which is a side problem), what is the point of having another two commands enroll and expel? If you want to make enroll and expel meaningful, you shouldn't allow users to directly edit the tutorial group. To me, this does not make sense. The features do not cohesively form a meaningful product. I don't think my bug report is a duplicate of the 'original' one.


:question: Issue type

Team chose [type.FunctionalityBug] Originally [type.FeatureFlaw]

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]