Open Hongyi6328 opened 2 years ago
Same issue with #5386: allowing student to be enrolled to non-existing tutorial group
[The team marked this bug as a duplicate of the following bug]
Students that are assigned to some tutorial groups that don't exist cannot be expelled
Student 1 is assigned to tutorial group T01 which doesn't exist and he can't be expelled from it.
[original: nus-cs2103-AY2223S1/pe-interim#5194] [original labels: severity.Medium type.FunctionalityBug]
[This is the team's response to the above 'original' bug]
also because of the same reason. this wrong version jar file (1.3) dosent check the tutorial group's existence when enrolling. fixed in 1.4
Items for the Tester to Verify
:question: Issue duplicate status
Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)
Reason for disagreement: The main issue of my bug is not that students can be enrolled to non-existing tutorial group. What I meant is more of a feature flaw - if you allow users to directly edit the tutorial group (yes, this tutorial group can be non-existing, too, which is a side problem), what is the point of having another two commands enroll
and expel
? If you want to make enroll
and expel
meaningful, you shouldn't allow users to directly edit the tutorial group. To me, this does not make sense. The features do not cohesively form a meaningful product. I don't think my bug report is a duplicate of the 'original' one.
Team chose [type.FunctionalityBug
]
Originally [type.FeatureFlaw
]
Reason for disagreement: [replace this with your explanation]
Team chose [severity.Medium
]
Originally [severity.Low
]
Reason for disagreement: [replace this with your explanation]
Then the
enroll
,expel
commands seem meaningless. Also, the user can change the tutorial group to be a non-existing group.student edit 1 n/James Hoh p/98765432 e/a@gmail.com g/T99 t/yearTwo