🐛[BUG][Combat] Mobs use OoE spells and spells from jobs other than their own

[TracentEden]

What does this bug affect? Aura Pots in The Shrine of Ru'Avitau use OoE spells such as Stone V and Bio III (see https://github.com/EdenServer/community/issues/5123 for equivalent bug that impacted Eden and era proof)

Steps to Reproduce

Expected behavior

Screenshots

Setup Information

Additional context

[TracentEden]

To generalize on this other BLM mobs (such as steam cleaner) also cast OoE spells (such as Water V), according to Era wiki pages (such as https://ffxiclopedia.fandom.com/wiki/Stone_V?oldid=724119) only a few select mobs could cast T5 spells:

Specifically these included: Stone V: Kirin and Nightmare Worm (https://ffxiclopedia.fandom.com/wiki/Stone_V?oldid=724119) Water V: none (no era page) Aero V: Absolute Virtue (https://ffxiclopedia.fandom.com/wiki/Aero_V?oldid=724123) Fire V: Bahamut in Storms of Fate (https://ffxiclopedia.fandom.com/wiki/Fire_V?oldid=724126) Blizzard V: none (no era page) Thunder V: NPC Azima (https://ffxiclopedia.fandom.com/wiki/Thunder_V?oldid=724121)

ASB and testing shows that many mobs beyond these have access (see https://github.com/AirSkyBoat/AirSkyBoat/blob/staging/sql/mob_spell_lists.sql) including beastmen BLM, magic pots, worms, etc.

For T4 -GA spells the only potential issue seems to be that Nightmare Worm is missing Stonega IV and Animated Staff has Stonega IV when maybe should not (https://ffxiclopedia.fandom.com/wiki/Stonega_IV?oldid=724118)

[TracentEden]

Additional Spells that should probably be limited:

Holy II: Alexander, Proto-Ultima, Razfahd (https://ffxiclopedia.fandom.com/wiki/Holy_II?oldid=724138) Cure VI: none (no era page) Regen IV: none (no era page) Aspir II: none (no era page) Foe Requiem VII: none (no era page) Horde Lullaby II: none (no era page) Army's Paeon VI: none (no era page)

I am less familiar with the ninja and blu spells and they may be less likely to have era pages even if certain mobs did use them in era.

Also Steam Cleaner should only use thunder based spells (https://ffxiclopedia.fandom.com/wiki/Steam_Cleaner) rather than having access to the full set of spells of normal BLM magic pot mobs.

As a more general point, the mob_spell_lists probably needs to be reworked to split other mob families by jobs so they cast only the spells they should be allowed to cast by job. For example, Olla sky NMs have different jobs yet I think all use the same magic pot BLM spell pool. Also it appears that Olla Media and Olla Grande have wrong jobs and should be DRK/BLM and WHM respectively (instead of RDM).

The following splits should probably be made based on jobs of mob families that are already specified in mob_spell_lists: Worm: BLM, RDM Ahriman: BLM, RDM? Undead: BLM, DRK Magicpot: BLM, RDM, DRK (maybe only Olla Media), WHM (maybe only Olla Grande)

[Frankie-hz]

Current Draft PR: https://github.com/AirSkyBoat/AirSkyBoat/pull/510

Can comment on that if you see anything wrong - can finish it up tomorrow @TracentEden

[TracentEden]

Yeah, based on the spell casting rate I saw I think reasonable to assume that Olla Pequena has access to all T4 and T3-ga BLM spells and elemental dots but that I just didn't see them because it has such a large spell pool. Similar logic with Olla Media and the absorb spells and Olla Grande with protect IV. Though I understand if you just want to stick with the actually observed spells. I do not see any other issues with the PR.