Mention include: "credentials" in authentification docs

HoudiniGraphql / houdini

The disappearing GraphQL framework

http://www.houdinigraphql.com

MIT License

913 stars 99 forks source link

Mention include: "credentials" in authentification docs #1345

Closed ewen-lbh closed 3 months ago

ewen-lbh commented 3 months ago

Hi! I spent way too much time trying to figure out why "Houdini isn't passing cookies to the API while Svelte is", after switching to OAuth2-backed authentication with HTTP-Only cookies.

This is just a friendly reminder, not something Houdini-specific, but it'll surely prevent some tickets ^^

To help everyone out, please make sure your PR does the following:

[x] Update the first line to point to the ticket that this PR fixes
[x] Add a message that clearly describes the fix
[x] If applicable, add a test that would fail without this fix
[x] Make sure the unit and integration tests pass locally with pnpm run tests and cd integration && pnpm run tests
[x] Includes a changeset if your fix affects the user with pnpm changeset

changeset-bot[bot] commented 3 months ago

⚠️ No Changeset found

Latest commit: a4d53fb3f31aade626b1dffb1791eb87fb4f0745

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

netlify[bot] commented 3 months ago

Deploy Preview for houdini-docs-next ready!

Name	Link
Latest commit	a4d53fb3f31aade626b1dffb1791eb87fb4f0745
Latest deploy log	https://app.netlify.com/sites/houdini-docs-next/deploys/66c7a32308104d0008e7d073
Deploy Preview	https://deploy-preview-1345--houdini-docs-next.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.