Added countdown to start of match. - Githubissues

HouraiTeahouse / FantasyCrescendo

A 2.5D Touhou Platform Fighter, By the fans, for the fans.

https://docs.houraiteahouse.net/FantasyCrescendo

GNU General Public License v2.0

105 stars 29 forks source link

Added countdown to start of match. #297

Closed LadyEbony closed 6 years ago

LadyEbony commented 6 years ago

Motivation and Context

[X] Why is this change required? What problem does it solve? James asked me.
[ ] If it fixes an open issue, include the text Closes #1 (where 1 would be the issue number) to your commit message.

Types of changes

What types of changes does your code introduce? Check all the boxes that apply:

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality) Added a countdown UI to Stage GUI. Added boolean variable to MatchManager, which influences input from MatchController.
[ ] Breaking change (fix or feature that would cause existing functionality to change)

Description

[ ] Describe your changes in detail. MatchManager now begins a countdown Task before the MatchStartEvent. During that period, new MatchManager variable, isControllerLocked, is set to true, which disables input from MatchController. Once the countdown finishes, isControllerLocked is set to False and MatchStartEvent is called as usual.

If I am doing something unpleasant in the code, please tell me. Not familiar with Tasks nor this project's code standards.

LadyEbony commented 6 years ago

Made changes requested. Check commits for all changes.

LadyEbony commented 6 years ago

Made change requests to improve code quality.