search

HristoKolev / TvDbSharper

TvDbSharper is fully featured modern REST client for the TheTVDB API v4
MIT License
29 stars 17 forks source link

SearchSeriesResult doesn't have a Language tag? #6

Closed da3dsoul closed 7 years ago

da3dsoul commented 7 years ago

This may be on the fault of the API. I'll admit I haven't looked. The xml api had Language tags for search results. SearchSeriesResult doesn't have it. Is it assumed "en"? The are situations where you get not English results due to foreign releases. Disney is plagued with that, Studio Ghibli anime (Spirited Away, Castle in the Sky, etc) as well.

HristoKolev commented 7 years ago

This is what the API returns:

{
  "aliases": [
    "string"
  ],
  "banner": "string",
  "firstAired": "string",
  "id": 0,
  "network": "string",
  "overview": "string",
  "seriesName": "string",
  "status": "string"
}

https://api.thetvdb.com/swagger#!/Search/get_search_series

da3dsoul commented 7 years ago

I see. You pass language as a header, and then everything returned will only be of that language.

HristoKolev commented 7 years ago

Yes. You set de to the AcceptedLanguage property of the client and you get things in German.

da3dsoul commented 7 years ago

You have the language handled properly in the Client as well. Thanks, and closing.