search

Hubs-Foundation / hubs

Duck-themed multi-user virtual spaces in WebVR. Built with A-Frame.
https://hubsfoundation.org
Mozilla Public License 2.0
2.13k stars 1.42k forks source link

bitECS: rotating/scaling an object allows it to be captured by media frames #6405

Open Exairnous opened 10 months ago

Exairnous commented 10 months ago

Description If you rotate or scale an object via the spacebar menu when it is close to a media frame, you can rotate/scale it so that it intersects and is captured. Also, the media frame bounds aren't shown when rotating/scaling and neither is the preview.

To Reproduce Steps to reproduce the behavior:

  1. Go to a room with the new loader enabled and with this scene: https://hubs.mozilla.com/scenes/qgaMVT9/mediaframealignment
  2. Spawn in an object.
  3. Move it near a media frame.
  4. Open the spacebar menu and either rotate or scale it until it intersects the media frame and is captured without you even finishing the rotate/scale.

Expected behavior Media frames shouldn't capture objects when rotating/scaling, or at the very least should show their bounds and the normal capture preview, and they shouldn't capture it until the rotation/scale is finished.

Videos Rotating: https://github.com/mozilla/hubs/assets/9795121/ff907fa5-0910-402e-b734-7c9d425fd736

Scaling: https://github.com/mozilla/hubs/assets/9795121/a2890621-379d-4323-874a-4368aee1b5a7

Hardware

Additional context The AFrame loader couldn't be tested because of https://github.com/mozilla/hubs/issues/6399