HyperText showLabels misbehaving

[victor-ab]

Describe the bug "null" label is displayed instead of no label name. when showLabels="false". Default behaviour also differs from what's specified in the documentation regarding showLabels. https://labelstud.io/tags/hypertext.html

To Reproduce Steps to reproduce the behavior: When annotating HyperText and adding showLabels="false", a "null" label is displayed.

Expected behavior No label name should be displayed when showLabels="false".

Screenshots

Environment (please complete the following information):

• Windows 11

  {
  "label-studio-os-package": {
  "version": "1.2",
  "short_version": "1.2",
  "latest_version_from_pypi": "1.2",
  "latest_version_upload_time": "2021-08-18T16:22:25",
  "current_version_is_outdated": false
  },
  
  "label-studio-os-backend": {
  "message": "Update LSF: fixes for relations on image (#1316)",
  "commit": "4b468fd2de049fc4a414e81e8a00cbf13bb1a284",
  "date": "2021-08-18 11:19:47 +0300",
  "branch": "HEAD",
  "version": "1.0.2+173.g4b468fd2.dirty"
  },
  
  "release": "1.2",
  "label-studio-frontend": {
  "message": "[fix] loading images with relations (#239)",
  "commit": "c02a287aef3bea907a09196bd2145c7225208efe",
  "branch": "master",
  "date": "2021-08-18T07:32:08Z"
  },
  
  "dm2": {
  "message": "Merge pull request #9 from heartexlabs/feature/regex-filter  [ext] Add ...",
  "commit": "e67fb3ab5bcabfb663a4e010503c83ecb3d2ed44",
  "branch": "master",
  "date": "2021-08-17T13:41:09Z"
  },
  
  "label-studio-converter": {
  "version": "0.0.30"
  }
  }

[makseq]

@smoreface please, check the docs about it

[smoreface]

hmm, @hlomzik seems like a bug? do docs describe the intended behavior (highlight occurs but label is not displayed), or is displaying "null" instead of the label intended behavior?

[hlomzik]

Hi! "null" is wrong for sure, that's not for humans :) This parameter is very rare, so there may be some errors. I'll check and fix it soon

[victor-ab]

@hlomzik Besides the "null", the showLabels default value is False in the docs, but True in reality

[victor-ab]

@hlomzik @makseq I am not a js specialist, but think I found the bug. I think it is here There should be a check for (label != null) before setting the label text attribute.

[hlomzik]

yes, looks like the right place, thanks! I'll try it today about showLables — it's complicated a bit, it has different default values for different object tags, but I'll check this as well