Closed rmcar17 closed 2 months ago
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
.nox/test-3-12/lib/python3.12/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-10/lib/python3.10/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-10/Lib/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-12/Lib/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-11/lib/python3.11/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-11/Lib/site-packages/diverse_seq/records.py | 8 | 91.89% | ||
.nox/test-3-10/Lib/site-packages/diverse_seq/data_store.py | 9 | 92.31% | ||
.nox/test-3-12/Lib/site-packages/diverse_seq/data_store.py | 9 | 92.31% | ||
.nox/test-3-11/lib/python3.11/site-packages/diverse_seq/data_store.py | 9 | 92.31% | ||
.nox/test-3-11/Lib/site-packages/diverse_seq/data_store.py | 9 | 92.31% | ||
<!-- | Total: | 231 | --> |
Totals | |
---|---|
Change from base Build 10733801195: | 0.6% |
Covered Lines: | 6729 |
Relevant Lines: | 7272 |
I noted something which I'd missed in my first review that is quite important. Support for parallel computation within Jupyter notebooks is difficult and the standard library does not support it. I've solved this in cogent3 by using the
loky
third-party library. Just use the cogent3as_completed()
function for this.
I've changed the implementation to also use loky
as well, as I relied more broadly on the Executor
interface
Method forms a so called "cluster tree" formed by pairwise comparison of the mash distance between sequences or euclidean distance between kmer frequencies of the sequences.