HwangTaehyun / react-native-lottie-splash-screen

⚡ Lottie splash screen for your react native app!
MIT License
222 stars 62 forks source link

[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md #67

Closed madmeatballs closed 1 year ago

madmeatballs commented 1 year ago

[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md

google-cla[bot] commented 1 year ago

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

HwangTaehyun commented 1 year ago

@madmeatballs Thank you!! LGTM! Could you change your commit to the following format?

[docs] Add RN 0.71 iOS setup on AppDelegate.mm to README.md

- Updated README.md for additional instruction on how to setup your lottie splash screen on AppDelegate.mm now that 0.71 doesn't give access to rootview by default.

Thank you for your contribution!

madmeatballs commented 1 year ago

Updated the commit message.

HwangTaehyun commented 1 year ago

Oh, What I meant was the real commit message. Sorry. Could you push again after editing?

madmeatballs commented 1 year ago

Oh, What I meant was the real commit message. Sorry. Could you push again after editing?

will do, I'll close this and open an new one