Hydrospheredata / hydro-serving

MLOps Platform
http://docs.hydrosphere.io
Apache License 2.0
271 stars 42 forks source link

Dropping container when wrong runtime #178

Closed tidylobster closed 5 years ago

tidylobster commented 6 years ago

If runtime wasn't set correctly on creating application, it might cause problems with corresponding docker container. Invoking that application will likely fail, but moreover, user will not know, what happened, as there is no proper warning message. After invocation, runtime container will be dropped(removed).

KineticCookie commented 6 years ago

Note: there is already an API that returns list of runtimes for a modelType. However, since the field is set by a user for both models and runtimes, it doesn't guarantee that runtime actually won't crash on initialization.

Ultimately we need a container validation after initialization mechanism, so we could interrupt the creation of app services and remove the app.