Improved MultidimArray performance

I2PC / xmippCore

Core functions for Xmipp and sharing with other packages (like Scipion)

GNU General Public License v3.0

4 stars 2 forks source link

Improved MultidimArray performance #167

Closed oierlauzi closed 1 year ago

oierlauzi commented 1 year ago

Tried to fix 2 issues regarding MultidimArray performance.

Added move constructor and move assignment. This improves performance when a R-value is asssigned.
Modified copies when resizing to make use of memcpy instead of manual copies.

oierlauzi commented 1 year ago

Program tests have succeed. Protocol tests are still ongoing

albertmena commented 1 year ago

Program tests have succeed. Protocol tests are still ongoing

Protocol tests pass, at least the ones passed before this branch

albertmena commented 1 year ago

Could you provide a small summary about the impact of this implementation @oierlauzi ? speedup of programs? which one?. If performance optimization were applied, we must inform about it in the next release. Thanks and great job

albertmena commented 1 year ago

merge devel into this branch and resolve the conflict please

sonarcloud[bot] commented 1 year ago

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
1 Code Smell

0.0% Coverage
0.0% Duplication

albertmena commented 1 year ago

Better performance of resizeCopy and resize in multdimarray and also in structures std::vector<Multidimarray>