Please confirm that this PR has done the following:
[x] Tests Added
[ ] Documentation Added
~Name of contributors Added to AUTHORS.rst~
[ ] Description in RELEASE_NOTES.md Added
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
- (#XX)[http://link-to-pr.com] Added feature which does something
Description of PR
This PR excises the "exclude" column from the "meta" attribute to reduce confusion among users why an exclude column is added (but then again not imported to the IIASA Scenario Explorer.
The PR:
creates a new attribute exclude and refactors all validation methods such that the argument exclude_on_fail changes this attribute
extends the filter such that filter(exclude=<value> works as expected
adds "exclude" to the list of illegal column names for (timeseries) data and meta
when importing an xlsx file created with pyam < 2.0 (which has an "exclude" column in "meta"), that column is moved to the new exclude attribute (with a log message)
danielhuppmann
commented
1 year ago
Please confirm that this PR has done the following:
Adding to RELEASE_NOTES.md (remove section after adding to RELEASE_NOTES.md)
Please add a single line in the release notes similar to the following:
Description of PR
This PR excises the "exclude" column from the "meta" attribute to reduce confusion among users why an exclude column is added (but then again not imported to the IIASA Scenario Explorer.
The PR:
excludeand refactors all validation methods such that the argumentexclude_on_failchanges this attributefilter(exclude=<value>works as expectedexcludeattribute (with a log message)fyi @gidden @byersiiasa @phackstock
closes #755