Closed djrodgerspryor closed 4 months ago
@bmulholland Maybe I've done something wrong but I'm not sure this fixes https://github.com/IAPark/tiktoken_ruby/issues/20
@karlentwistle you will still need to install libclang
Does anyone know a good way to install libclang
on Heroku? It appears to no longer be included in the build environment on the heroku-22 stack.
@karlentwistle you will still need to install libclang
Ah, I see, thanks very much for letting me know 🙇
Does anyone know a good way to install libclang on Heroku? It appears to no longer be included in the build environment on the heroku-22 stack.
I got it working with https://github.com/karlentwistle/tiktoken_heroku_example/commit/583a5c75c734ded7500e5f0cf7da0196c5a4108f and https://elements.heroku.com/buildpacks/heroku/heroku-buildpack-apt
Can also now confirm this PR does indeed fix https://github.com/IAPark/tiktoken_ruby/issues/20 😄
Howdy @IAPark, this is blocking projects from moving to Ruby 3.3. Any chance this can be merged?
Curious. Why is libclang
required now when it wasn't on Ruby 3.2? Did Ruby 3.2 handle it or did Tiktoken not require the dependency?
@ScotterC Maybe because there's a prebuilt version for ruby 3.2, but not 3.3? Ref: https://github.com/IAPark/tiktoken_ruby/issues/20#issuecomment-1910245815
Yup here's where the builds are created https://github.com/IAPark/tiktoken_ruby/blob/main/.github/workflows/build.yml#L9. If I understood more clearly how that build ends up creating the precompiled version on rubygems or locally then I'd create a PR for it. I'm loathe to add another buildpack to Heroku since I'm feeling the platform lock-in lately.
Did anyone here fork the gem for Ruby 3.3 ?
@xfalcox only forks updated recently are similar to this PR. Updating rb_sys. Here's thoughtbot's https://github.com/thoughtbot/tiktoken_ruby
Closed in favor of https://github.com/IAPark/tiktoken_ruby/pull/22 (kinda by accident)
Also, the truth is I created this gem in a weekend because I was annoyed at work and we've sense moved in a direction where it's irrelevant. It kinda just gives me a bit of stress now when I'm reminded of it. I think I should probably put a notice up asking if anyone wants to take it over
In theory this should be out now though cross compiling seems broken and I might not be able to get back to it until next weekend at the earliest
@IAPark thanks for the work! I'll see if I can help find a maintainer
The tests pass and this seems to work perfectly as far as I can tell.