search

IARI / alsa_jack_gui

qt-based gui to manage alsa_jack bridges
8 stars 3 forks source link

feature request: please add support for zita-a2j and zita-j2a #1

Open shimpe opened 6 years ago

shimpe commented 6 years ago

these are "improved" alsa_in and alsa_out replacements (better performance, better quality resampling)

IARI commented 6 years ago

The crucial parts of the code are

    @property
    def cmdName(self):
        # TODO: support alternative bridges, i.e. zita-ajbridge
        return "alsa_{}".format("in" if self._in else "out")

in interface.py line 32 and

CMD_PAT = '{cmd} -j "{name}" -d {hw}'

in interface.py line 92

apparently at some point i had already planned for this, but since then I didn't do any Jack development Currently I have no system running Jack I'm working on, so I can't test anything. But probably you can just replace "alsa_{}".format("in" if self._in else "out") with "zita-{}".format("a2j" if self._in else "j2a") (or maybe a2j needs to be swapped with j2a) Let me know, if that worked for you.

shimpe commented 5 years ago

Just replacing the way you suggested works perfectly! Thanks.

darinrogers commented 1 month ago

@IARI I could submit a PR, or fork this repository with the changes to use zita-ajbridge instead. I just started using it with the patch you proposed and should know pretty quickly if it's stable. It immediately seems better than alsa_in/alsa_out.