search

IAS-Astrophysics / athenak

Performance-portable version of the Athena++ astrophysical AMR-MHD code using Kokkos.
BSD 3-Clause "New" or "Revised" License
35 stars 25 forks source link

fixing restart for amr #300

Closed jmstone closed 3 months ago

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Feb 27, 2023, 09:46

Restart functionality is broken in the current master when amr is used. This is a fix with minimal changes that update the nmb definition in restart.cpp and pgen.cpp, and fix a typo in build_tree.cpp regarding the maximum level.

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Feb 27, 2023, 09:46

requested review from @jmstone216

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Feb 27, 2023, 09:50

added 1 commit

Compare with previous version

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Mar 1, 2023, 08:50

approved this merge request

jmstone commented 3 months ago

In GitLab by @jmstone216 on Mar 1, 2023, 10:42

Can we chat about these changes? I don't understand the change in build_tree, and the changes to the restart file will cause the entire MB array to be written even if many of the MBs are empty. Instead I think we need to create a subview of the MB array of size nmb_thisrank and write that out.

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Mar 2, 2023, 08:31

Of course! I agree that creating a subview would make more sense. I will look into this tomorrow!

As for the max_level, I found removing that -1 is necessary from testing: so even if the shape of the arrays are corrected, if you restart from the checkpoint file, you would find that the level of refinement would be increased until the number of meshblocks goes beyond max_nmb_per_rank. I found that this is caused by the change in max_level, namely before and after restart, max_level changed by one. But this difference by 1 could be caused by other where of course.

Should we chat in person at some point about these changes?

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Mar 7, 2023, 07:48

added 11 commits

Compare with previous version

jmstone commented 3 months ago

In GitLab by @Hengrui_Zhu on Mar 7, 2023, 07:57

added 1 commit

Compare with previous version

jmstone commented 3 months ago

In GitLab by @jmstone216 on Jun 29, 2023, 09:57

This MR has been superceded by !126