IAS-Astrophysics / athenak

Performance-portable version of the Athena++ astrophysical AMR-MHD code using Kokkos.
BSD 3-Clause "New" or "Revised" License
35 stars 25 forks source link

Fixed Point and ScratchTensor constructors. #615

Closed jfields7 closed 1 week ago

jfields7 commented 1 week ago

This is a hotfix to the PointTensor and ScratchTensor templates in athena_tensor.hpp so that this file will compile correctly on AMD GPUs. Some of the template specializations declared their constructors with KOKKOS_INLINE_FUNCTION but then defined the constructors outside the class without. This is not generally consistent, and it's honestly a bit of a surprise that it compiled at all on other architectures.