search

IBM-Cloud / gp-js-client

JavaScript/Node.js client for Globalization Pipeline
https://developer.ibm.com/open/ibm-bluemix-globalization-pipeline-service/node-js-sdk/
Apache License 2.0
8 stars 24 forks source link

fix use of deprecated Buffer in hmac #157

Closed srl295 closed 5 years ago

srl295 commented 5 years ago

See: https://nodejs.org/api/deprecations.html#deprecations_dep0005_buffer_constructor

The use of Buffer() was deprecated, the API used in this PR dates from Node version 5, and we require Node version 8+ for this SDK. So it is a safe replacement.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 84.605% when pulling 36342dc222ac208bf9d5b3af708e8a4e2734e399 on fix-buffer into 0e649dabcacd7b97313de69d87e8415a0c528ab6 on master.

srl295 commented 5 years ago