IBM / dbb-zappbuild

zAppBuild is a generic build solution for building z/OS applications using Apache Groovy build scripts and IBM Dependency Based Build (DBB) APIs.
Apache License 2.0
40 stars 140 forks source link

Strategy to record logical files but skip scanning them #308

Closed dennis-behm closed 1 year ago

dennis-behm commented 1 year ago

There are multiple artifacts which don't need to be scanned - for instance XML, JCL, PROCS and others. However, users would like to record them as a logical file to be able to use it in impact analysis, see also #200 .

Summary of changes:

M-DLB commented 1 year ago

Hi @dennis-behm - This looks good to me, just to confirm, why do you also define the dbb.scannerMapping = DependencyScanner in file.properties? If it's defined in build-conf/defaultApplicationSettings.properties, that should be sufficient, no?

dennis-behm commented 1 year ago

Hi @dennis-behm - This looks good to me, just to confirm, why do you also define the dbb.scannerMapping = DependencyScanner in file.properties? If it's defined in build-conf/defaultApplicationSettings.properties, that should be sufficient, no?

@M-DLB - I kept in both places. The definition in build-conf/defaultApplicationSettings.properties would be indeed sufficient. I specifically inserted it in build-conf to preserve backward compatibility. Maybe some applications have some specific requirements and need to define it in file.properties. Lets comment the definition in file.properties out and put in a reference to the defaults being defined in build-conf/defaultApplicationSettings.properties. How does that sound to you?

M-DLB commented 1 year ago

@dennis-behm Sounds good yes, it makes sense keep it commented in file.properties in case of any override needed.

dennis-behm commented 1 year ago

Based on a discussion with @drbruce-git , I am going to change the implementation to use the DependencyScannerRegistry API

dennis-behm commented 1 year ago

@drbruce-git, please review the changes of this implementation. It is now moved to the DependencyScannerRegistry API of DBB.