IBM / keyprotect-nodejs-client

Nodejs SDK for interacting with the IBMCloud KeyProtect service.
Apache License 2.0
0 stars 10 forks source link

Signed-off-by: Bharath Sakthivel <bharath.sakthivel@ibm.com> #20

Closed bharath-sakthivel closed 2 years ago

bharath-sakthivel commented 2 years ago

ran detect-secrets As part of “IBM Cloud 3Q2022: FS-IA readiness”, all the IBM/KMS repositories must enable “Detect Secrets” tool detect secrets, also scan and audit the secrets in their repositories before 8/21/2022.

In this PR I’ve enabled “detect-secrets” and also scanned this repository. The results are in file .secrets.baseline.

I request that the team audit the potential secrets discovered in this scan.

Action to take by any contributor of this repo before merging

The setup should be quick. The audit itself will take only a few minutes on each repo or maybe 10 minutes on a very large repo.

Installation of secret detect is quick, but there is also a docker method available if you have docker desktop that takes no setup (Using docker to run detect secrets).

For further info on detect-secrets please visit: https://w3.ibm.com/w3publisher/detect-secrets/developer-tool

FYI : Henry Grantham, Dinesh Venkatraman Thanks

codecov[bot] commented 2 years ago

Codecov Report

Merging #20 (7c55b55) into master (ce5ab06) will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##            master       #20   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          416       416           
  Branches        59        59           
=========================================
  Hits           416       416           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

dinesh-venkatraman-g commented 2 years ago

Covered as part of the PR https://github.com/IBM/keyprotect-nodejs-client/pull/21