IBM / rl-testbed-for-energyplus

Reinforcement Learning Testbed for Power Consumption Optimization using EnergyPlus
MIT License
179 stars 74 forks source link

Not compatible to the latest version of EnergyPlus #8

Open takaomoriyama opened 5 years ago

takaomoriyama commented 5 years ago

The current version is not compatible to the latest version of EnergyPlus (https://github.com/NREL/EnergyPlus/releases/tag/v9.1.0)

takaomoriyama commented 5 years ago

@antoine-galataud Thank you for the patch for EP 9.1.0. I've committed it to the master branch. Please let me try on my Ubuntu 16 environment. BTW. Don't you think the shar file of EP 9.1.0 for Linux (EnergyPlus-9.1.0-08d2e308bb-Linux-x86_64.sh) is corrupted ? I mean when I feed it to bash, the code was installed under /usr/local instead of /usr/local/EnergyPlus-9-1-0 because tar image included in the shar file is created under /usr/local/EnergyPlus-9-1-0. How did you solve it ?

antoine-galataud commented 5 years ago

@takaomoriyama I've faced the same problem. I haven't solved it yet, just applied a simple workaround: give /usr/local/EnergyPlus-9-1-0 when prompted so it's installed correctly. Symbolic links fail to install though, but it's not preventing it from running correctly. I was planning to create an issue on NREL side, but didn't have time yet.

antoine-galataud commented 5 years ago

@takaomoriyama the issue has already been reported: https://github.com/NREL/EnergyPlus/issues/7256 I guess the fix will apply to 9.2.0

takaomoriyama commented 5 years ago

@antoine-galataud Thanks for the info. I created a tentative patch for anyone who want to try EP 9.1.0, and placed it at https://github.com/IBM/rl-testbed-for-energyplus/blob/master/EnergyPlus/EnergyPlus-9.1.0-08d2e308bb-Linux-x86_64.sh.patch. Please use it as follows

$ patch -p0 < rl-testbed-for-energyplus/blob/master/EnergyPlus/EnergyPlus-9.1.0-08d2e308bb-Linux-x86_64.sh.patch
antoine-galataud commented 5 years ago

@takaomoriyama I tested your patch and I confirm it fixes the install issue. Thx.