search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Fix/Generic error for PV not found in DB (for plugin identification the PV existence) #216

Closed shay-berman closed 6 years ago

shay-berman commented 6 years ago

Refactor volumeNotFoundError in database to be standard error for StorageClient interface.

Move this error from scbe backend to be generic for ubiqutiy StorageClient interface, So the plugins will be able to identify if the GetVolume interface fail to find the volume because an error or because it was not found in Ubiqutiy DB. The first to use it in the plugin is the flex Unmount CLI to identify if PV exist in ubiquity before unmount start (for idempotent issue resolving)

This PR related to k8s plugin -> https://github.com/IBM/ubiquity-k8s/pull/193

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 51.873% when pulling 0c882da7298614d6c4997717e832bf1ab3100ed2 on fix/idempotent_umount_improvments into a9fe98db89ece7dd4dd634e6e31bcdc3b77753fb on dev.

olgashtivelman commented 6 years ago

Reviewed 7 of 7 files at r1. Review status: all files reviewed at latest revision, all discussions resolved.

Comments from Reviewable

olgashtivelman commented 6 years ago
:lgtm:

Review status: all files reviewed at latest revision, all discussions resolved, all commit checks successful.

Comments from Reviewable