search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

UB-1405: unmount flow should not fail if discovery fails #229

Closed olgashtivelman closed 6 years ago

olgashtivelman commented 6 years ago

In this PR , the following idempotent issue with Unmount flow is fixed: if a discovery of a volume fails, no need to fail the Unmount command, just need to skip the UnmountDeviceFlow.

more info: if volume's mpath NOT discovered (because the device does not exist at all in multipath -ll) then we should skip UnmountDeviceFlow instead of failing (reminder - the UnmountDeviceFlow is the flow that does umount the device and cleanup of the mpath device) .
Why its idempotent? - because there is a chance that unmount flow will fail at the end of UnmountDeviceFlow after it unmounts and cleans the mpath device. So to be idempotent the unmount needs to handle unmount request while the mpath device was already cleaned.

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.5%) to 57.133% when pulling 3e45a8a5d1e198b24de24884a094b7a6d11dedfa on fix/UB-1405_unmount_should_not_fail_if_mpath_isnot_discovered into 0246249a321902ddc1901f732d683fe5819b37ec on dev.

shay-berman commented 6 years ago

please add the internal ticket number that this PR refer to.