IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

UB-1474: added logging message to indicate an idempotent issue #233

Closed olgashtivelman closed 6 years ago

olgashtivelman commented 6 years ago

added a log message to indicate that a device was already unmounted. as part of this message we needed to add the volume WWN (to enable the automation to work and check this case) so some changes in the API were made to support this.


This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage increased (+0.02%) to 51.98% when pulling 71e9d8fb487524073d4c84b3e20bce7ea4e3f5ba on fix/UB-1474_add_idempotent_message into 01b687168ce391d7066bf487e3dd57afbbc4c5bf on dev.

beckmani commented 6 years ago

remote/mounter/block_device_mounter_utils/block_device_utils_mounter_test.go, line 280 at r1 (raw file):

      It("should fail if unmount failed", func() {
          fakeBlockDeviceUtils.UmountFsReturns(callErr)
          err = blockDeviceMounterUtils.UnmountDeviceFlow("fake_device", "")

I would expect to have here a valid wwn string format

beckmani commented 6 years ago

remote/mounter/block_device_mounter_utils/block_device_utils_mounter_test.go, line 287 at r1 (raw file):

          fakeBlockDeviceUtils.UmountFsReturns(nil)
          fakeBlockDeviceUtils.CleanupReturns(callErr)
          err = blockDeviceMounterUtils.UnmountDeviceFlow("fake_device", "")

I would expect to have here a valid wwn string format

beckmani commented 6 years ago

remote/mounter/block_device_mounter_utils/block_device_utils_mounter_test.go, line 295 at r1 (raw file):

          fakeBlockDeviceUtils.UmountFsReturns(nil)
          fakeBlockDeviceUtils.CleanupReturns(nil)
          err = blockDeviceMounterUtils.UnmountDeviceFlow("fake_device", "")

I would expect to have here a valid wwn string format

beckmani commented 6 years ago

remote/mounter/block_device_utils/fs.go, line 101 at r1 (raw file):

      }
      if !isMounted {
          b.logger.Info("Idempotent issue encountered - Device already unmounted.", logs.Args{{"mpath-device", mpoint}, {"volume-wwn", volumeWwn}})

Please specify the type of the Idempotent - "Idempotent (Mount) encountered....."