search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Support S390X images in Ubiquity CI helper scripts #238

Closed shay-berman closed 6 years ago

shay-berman commented 6 years ago

Add support for Ubiquity Z images (s390x architecture) in the helper CI scripts. So the CI scripts will also push s390x ubiqutiy images from an internal registry to external registry, and also create the ubiqutiy docker manifest with the new s390x image architecture (before this PR the helper scripts supported only P and X architecture).

Below the description of the CI scripts changes to support Z images:

  1. changes in [helper_to_push_docker_manifest.sh]:

    • The script gets another argument for Z image (in addition to P and X images).
    • The script pushes also the Z image from internal registry to external registry and creates the manifest with X, P and Z images.
    • In addition the script validates that the new manifest has 3 different architectures.

  2. Changes in [helper_to_push_ubiquity_images_and_manifests.sh]:

    • The script gets new environment variables for Z images (in\out and manifest for ubiquity, ubiquity-db, flex and provisioner).
    • Run for each ubiqutiy app an additional call to handle ubiqutiy Z images.
    • Refactor to reduce code duplication for every ubiqutiy app.

Internal ticket : UB-1385

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 48.144% when pulling c5f7ac786b8d1e280f0f431e5e3338ec5b88c8a1 on feature/support_zImages_in_helper_scripts into 382fc6e1cff9874a86702fc265ff97ac9a4388d8 on dev.