search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

Fix/ub 1060 unmount should continue on faulty device #246

Closed olgashtivelman closed 6 years ago

olgashtivelman commented 6 years ago

This PR is solving the following idempotent issue: in case the umount process fails after the volume is already detached in the storage but the multipath device still exists, the next umount we will try to run will fail and get stuck on the "umount" command forever. the solution is to run the dmsetup command before the umount command (dmsetup puts 0 to queue_if_no_path). this seems to solve the issue for this scenario and we are able to finish the umount without further issues.

This change is Reviewable

coveralls commented 6 years ago

Coverage Status

Coverage decreased (-0.02%) to 51.96% when pulling 69c7022e2da1fd6a3bbb4134c5c72abcddcd1f81 on fix/UB-1060_unmount_should_continue_on_faulty_device into 76dfee6814110b28ffa0fffb8586163b06de7301 on dev.