search

IBM / ubiquity

Ubiquity
Apache License 2.0
90 stars 26 forks source link

change LunNumber from float64 to int #296

Closed 27149chen closed 5 years ago

27149chen commented 5 years ago

change LunNumber from float64 to int. LunNumber should be int, but after json.Marshal and json.UNmarshal it will become float64. see https://stackoverflow.com/questions/39152481/unmarshaling-a-json-integer-to-an-empty-interface-results-in-wrong-type-assertio

This change is Reviewable

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 66.484% when pulling 98a7be509995273cf997bc68b602bec108de4f96 on feature/UB-1942_lunnumber_float_to_int into 7fb78c7959ae1e3715374689670ea4215d11e2e4 on dev.

shay-berman commented 5 years ago

LGTM