Feedback on the Langraph agent template

IBM / watson-machine-learning-samples

Watson Machine Learning sample models, notebooks and apps.

Apache License 2.0

106 stars 118 forks source link

Feedback on the Langraph agent template #50

Closed alexgseymour closed 1 day ago

alexgseymour commented 3 days ago

Issue to provide feedback on the Langraph agent deployment template - https://github.com/IBM/watson-machine-learning-samples/tree/master/cloud/ai-service-templates/function-calling

alexgseymour commented 3 days ago

Git clone command clones the entire cloud repo, can we scope this to the specific template
Can we have a dependencies section in the guide e.g. what developers already need installed and how e.g. pipx
Would recommend we rename the directory to langraph-agent to more accurately represent what the template is focused on.
Do we need the subdirectory /ai_service_function_calling within the /src directory. May be cleaner to have those files directly within the /src directory.
Need some documentation on how to handle sensitive values

dglozic commented 3 days ago

I strongly recommend comparing notes with x.ai Agent Builder team. Our generated AI Service code using LangGraph supports streaming in a message format compatible with OpenAI and Chat API streaming messages for tool calling, tool results and final LLM token chunks. It would be good to be consistent here since AI Services can technically return anything and we can cause a lot of inconsistencies if not defining a recommended streaming schema.

LukaszCmielowski commented 1 day ago

Let's move that conversation to IBM github.