search

IBM / zshot

Zero and Few shot named entity & relationships recognition
https://ibm.github.io/zshot
MIT License
350 stars 20 forks source link

Feat/zshot version #17

Closed marmg closed 2 years ago

marmg commented 2 years ago
Status Type ⚠️ Core Change Issue
Hold Refactor No

Problem

The version is in the setup.py file. This doesn't allow doing things like:

import zshot

print(zshot.__version__)

In latest version 0.3 of evaluate they don't receive a metric as a positional argument, it must be a keyword argument.

Solution

Moving the version to setup.cfg in the [metadata] field, as proposed in the official guide.

Add the metric as a keyword argument to the function call in the tests.

Other changes (e.g. bug fixes, small refactors)

codecov[bot] commented 2 years ago

Codecov Report

Base: 90.85% // Head: 90.85% // Increases project coverage by +0.00% :tada:

Coverage data is based on head (1250d15) compared to base (c44156d). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #17 +/- ## ======================================= Coverage 90.85% 90.85% ======================================= Files 48 48 Lines 1727 1728 +1 ======================================= + Hits 1569 1570 +1 Misses 158 158 ``` | [Impacted Files](https://codecov.io/gh/IBM/zshot/pull/17?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM) | Coverage Δ | | |---|---|---| | [zshot/\_\_init\_\_.py](https://codecov.io/gh/IBM/zshot/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-enNob3QvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [zshot/evaluation/evaluator.py](https://codecov.io/gh/IBM/zshot/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-enNob3QvZXZhbHVhdGlvbi9ldmFsdWF0b3IucHk=) | `96.77% <100.00%> (ø)` | | | [zshot/tests/evaluation/test\_evaluation.py](https://codecov.io/gh/IBM/zshot/pull/17/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM#diff-enNob3QvdGVzdHMvZXZhbHVhdGlvbi90ZXN0X2V2YWx1YXRpb24ucHk=) | `100.00% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=IBM)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.