search

IBMStockTrader / trader

UI microservice for the Stock Trader app
Apache License 2.0
23 stars 63 forks source link

Hide UI fields from disabled micro services #27

Open jwalcorn opened 1 year ago

jwalcorn commented 1 year ago

Right now we always show fields like the loyalty level, commissions, and sentiment that only actually have a meaningful value if the optional Account microservice is enabled (we show -1 for numbers, and "Unknown" for strings that aren't returned from Broker, which is probably confusing to new users). We should also only show the Return on Investment if the Trade History microservice is enabled, and the cash account balance if the Cash Account microservice is enabled. Also, only show the table of stocks if the portfolio has at least one stock (the table with just its headers looks goofy).

jwalcorn commented 1 year ago

Also, don't show the original "account balance" field, which was just about a balance from which to charge commissions, if the Cash Account microservice is enabled, as it is a superset of that original simple functionality

jwalcorn commented 1 year ago

I'll need to update the helm chart/operator to pass a few more env vars to Trader to enable this. We already have the fields in the CR yaml, we just aren't passing the values of those fields to the Trader microservice right now.