design system: login locale dropdown selector

[pirhoo]

Preview

[pirhoo]

Component is here: https://icij.github.io/datashare-client/?path=/docs/components-login-loginlocaledropdownselector--docs

[Soliine]

Awesome!

• Can you make the left padding here bigger?

• In my browser, I see a disconnection here, do you have it too and if yes, can you fix it if it is possible?

[pirhoo]

I increased the horizontal padding.

Regarding the arrow crispy pixel, unfortunately we can't do much as it drawn in CSS. But I suppose you only see it when you zoom in? It's the same arrow component that every other popover btw.

[Soliine]

It looks fabulous!

It's not only when I zoom in that I see it but it's ok if we can't do anything about it ;)

I notice that in dark mode, when I hover languages, there is the colored background

while it doesn't appear in light mode

[pirhoo]

It's legacy from the previous design, in fact both have a hover background but the contrast is not enough to be visible on light theme. I increased it:

[Soliine]

It looks great! Thanks for the explanations too