Add 'acre_api_fnc_getRadioOnOffState' to accessible method

IDI-Systems / acre2

Advanced Combat Radio Environment 2 (ACRE2) for Arma 3

https://acre2.idi-systems.com

GNU General Public License v3.0

205 stars 117 forks source link

Add 'acre_api_fnc_getRadioOnOffState' to accessible method #1339

Open gerard-sog opened 3 months ago

gerard-sog commented 3 months ago

When merged this pull request will:

Describe what this pull request will do:

Add 'acre_api_fnc_getRadioOnOffState' to accessible method.

gerard-sog commented 3 months ago

The two functions you have in PR don't add any behavior.
Adding a wrapper isn't going to magically make it work.

Need to check how GetVolume works and add necessary logic I think. (comments from people in Discord ACE : https://discord.com/channels/976165959041679380/976228128156446731/1275560027289026673)

Drofseh commented 3 months ago

getRadioOnOffState seems like a very clunky name to me, maybe something like getPowerState would be better?

gerard-sog commented 3 months ago

getRadioOnOffState seems like a very clunky name to me, maybe something like getPowerState would be better?

I don't think so since getRadioOnOffState already exists and changing the name to getPowerState would be a good idea if I also renamed all previous references to the old name then. Which is too much of a hassle for too little gain.

Drofseh commented 3 months ago

Ahh fair enough