search

IHEC / ihec-ecosystems

This repo is for code and documentation associated with the ihec-ecosystems working group
Apache License 2.0
5 stars 6 forks source link

UMI support + misc #109

Closed sitag closed 3 years ago

sitag commented 4 years ago

Still to add: umi string validation

dzerbino commented 3 years ago

Hello @sitag , In future could you create the new dev branch in a separate Pull Request? At present the diffs only show entirely new file, making review more complicated. Cheers, Daniel

sitag commented 3 years ago

As @dzerbino already mentioned, there are too many different issues in this PR. Going thoroughly through them would take a while. With regard to Curie validation: At the moment I only see "ncit:C115935xxxxxxxxx" as a test. The most common mistake is having a URI instead of a curie, hence that should be tested. Second, there can be multiple curies in the same field (CL:0000096;UBERON:0013756), which should also be tested.

Only last three commits address curie validation. This CL:0000096;UBERON:0013756 will fail validation as you can check. Right now we only do what @zxenia validator does. If you give uri where curie is expected it will not pass validation.