IHTSDO / snowstorm

Scalable SNOMED CT Terminology Server using Elasticsearch
Other
209 stars 84 forks source link

Concept search "returnIdOnly" format must use quoted ids to avoid javascript precision issue #367

Closed kaicode closed 2 years ago

kaicode commented 2 years ago

Concept ids that are 18 characters long get rounded when put into JSON as a number. For example "450229981000132104" is rounded to "450229981000132100".. the last two digits get changed to 0.

Snowstorm should always return SCTIDs as quoted Strings to avoid this problem. The concept search is not currently doing this when the returnIdOnly parameter is used. Running a search that matches concept "450229981000132104" returns an identifier of "450229981000132104" in the response. This is a bug.

https://snowstorm.ihtsdotools.org/snowstorm/snomed-ct/MAIN/concepts?conceptIds=450229981000132104&returnIdOnly=true

Screenshot 2022-01-31 at 15 37 39
kaicode commented 2 years ago

Fixed in release 7.7.0.