search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
284 stars 110 forks source link

'About IITC' dialog does not fit screen size #113

Closed johnd0e closed 4 years ago

johnd0e commented 5 years ago

Both Mobile and Desktop

modos189 commented 5 years ago

Why fit screen size on a desktop? Desktop uses windows that are not maximized

johnd0e commented 5 years ago

On desktop I see dialog with 'ok' button hidden under bottom edge of the screen

johnd0e commented 5 years ago

On mobile we need something like 'fullscreen dialogs'.

We cannot use HTML-only solution, because we need Back button in navigation drawer, which is provided by Java part of our app (see https://github.com/IITC-CE/ingress-intel-total-conversion/commit/b3a42783fad2e42289db9d9a1f6caab9ca1a7230#diff-cb38b2adb39e52661db8963cf7a52d3d).

Current mobile 'panes' are pretty close to what we need. But every pane is listed in left sidemenu, which is not good if we try to use it for plain dialogs.

Thoughts?

angel93ayora commented 5 years ago

Any way to redirect the "back" event from java to js?

modos189 commented 5 years ago

We can pass an event by clicking the Back button, but logic of working with the dialog stack is in the android application, so it is better not to mix them up.

We can add a parameter that disables the creation of an item in left sidemenu. You can open such a dialog box via android.switchToPane(id);

johnd0e commented 5 years ago

We can add a parameter that disables the creation of an item in left sidemenu. You can open such a dialog box via android.switchToPane(id);

Do you know how to do it? It's not that simple, as there should be pane with this id preregistered with android.addPane.

So simplest solution would be this: if there is no pane with specified id than open temporary dialog and use id as it's title (for actionbar).

BTW, current mobile panes API is far from good at all, and I am thinking about how it could be improved in general (#220).

johnd0e commented 5 years ago

It's also should be possible to style jQuery dialog to not exceed width/height.