search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
284 stars 110 forks source link

Bookmarks reorder error (& fix) #166

Closed angel93ayora closed 4 years ago

angel93ayora commented 5 years ago

Versions: bookmarks: 0.2.12.20190315.122355 iitc-ce: 0.29.1.20190315.122355

Enabled plugins: iitc-ce, bookmarks

Problem: reordering portals is failing reordering folders is failing moving portals between folders is failing

How to reproduce: create some bookmarks and/or folders to test the reordering, collapse the bookmarks box and re-open it

How to fix: (lines 626 and 639 of downloaded bookmarks plugin from iitc.modos189.ru) in function: window.plugin.bookmarks.jquerySortableScript in both update handlers change +ui.item.context.id per +ui.item[0].id

(!) This should be caused due to jquery updates, search for item.context on the entire codebase is suggested.

johnd0e commented 5 years ago

@angel93ayora Thank you for reporting!

Please check if latest of test-builds is working properly now.