Draw Tools Options / color selector

[MysticJay]

What is causing this broken style for the palette?

0,30.1 (release) with DT 0.7.1 does not show this. 0.30.1 (release) with DT 0.8.0 does not show this 0.30.1.20200720.132610 [test] with DT 0.8.0 shows problem

[McBen]

tracked it down to: 0c90913bb863597c4b4f66ff37c0fe182120a493 - external: update jQuery to 3.5.1

PR: https://github.com/IITC-CE/ingress-intel-total-conversion/pull/369

[McBen]

But the full truth is: It's a bug in spectrum: https://github.com/bgrins/spectrum/issues/563

a missing </span> in plugins/external/spectrum.js#143 should be: html.push('<span title="' + formattedString + '" data-color="' + tiny.toRgbString() + '" class="' + c + '"><span class="sp-thumb-inner" style="' + swatchStyle + ';" /></span></span>');

[johnd0e]

Quickfix:

var rxhtmlTag = /<(?!area|br|col|embed|hr|img|input|link|meta|param)(([a-z][^\/\0>\x20\t\r\n\f]*)[^>]*)\/>/gi;
jQuery.htmlPrefilter = function( html ) {
    return html.replace( rxhtmlTag, "<$1></$2>" );
};

[johnd0e]

a missing </span> in plugins/external/spectrum.js#143

True. And that is already fixed in upstream, so we need just upgrade spectrum to latest.

[MysticJay]

Confirming issue solved. still this is a workaround and night need to be reverted.

[MysticJay]

Solution accepted. upgrade provided with PR#382