search

IITC-CE / ingress-intel-total-conversion

intel.ingress.com total conversion user script with some new features. Should allow easier extension of the intel map.
https://iitc.app
ISC License
284 stars 110 forks source link

Storage permission request for mobile apk #4

Closed johnd0e closed 5 years ago

johnd0e commented 5 years ago

On start I've got only 1 permisson request: Location. And there were no request about Storage access which is necessary e.g. for external plugins.

I was able to set the permission manually but it will be better if it requested on apk start.

johnd0e commented 5 years ago

https://github.com/iitc-project/ingress-intel-total-conversion/pull/1286/commits/154e1bca058ff6dfd37a56dcfc72013329e915c7

modos189 commented 5 years ago

done

johnd0e commented 5 years ago

There are still some issues with it. I successfully set the permission and can access user scripts, but on every launch I still see the toast Permissions are required if you want to use user scripts or cache on SDCard.

modos189 commented 5 years ago

Request write storage permissions only if you add scripts. Saving the tile cache does not require additional permissions. https://github.com/IITC-CE/ingress-intel-total-conversion/commit/cdb7e89c47a53e4e991051d11b4461117fd1407c

johnd0e commented 5 years ago

Request write storage permissions only if you add scripts.

When I open *.user.js at Chrome webpage (or in file manager) it proposes list of applications. I select IITC and after confirmation all seems ok, but then Plugins settings screen appears without user plugins.

There should be permission request, I suppose.

And I think this even will not be enough, consider this case: IITC was once installed and we have user plugins in IITC-Mobile/plugins directory. Then we uninstall apk, and install it again. Will we get permission request?