search

IITGN-CS431 / project-cns

1 stars 27 forks source link

Functionality bug (Group-2) #305

Closed pranjal15195gaur closed 2 days ago

pranjal15195gaur commented 4 days ago

same command running directly but not on the client Screenshot 2024-11-18 223419

bichhawat commented 4 days ago

I am not sure what the issue is here. Can you please elaborate it?

pranjal15195gaur commented 4 days ago

Here, there is no constraint on the logfile name length normally, but when it is run on the client, there is a constraint on the length of the logfile name, which gives an error when run on the client. So, Either both should have the same constraint, or both should accept any length.

naveeeeeeeeeen commented 3 days ago

Hi @pranjal15195gaur,

This is not a bug per se.

Clients are not allowed to run ./setup, ./logappend, or ./logread directly, as these files are only present on the server side. Clients only have access to client.py, which they use to connect to the server and send commands.

Regarding the different behavior , the server will reject excessively long file names, close the connection for that client, and require a reconnection to send valid commands.

Refer to PR #323 and PR #324.

Screenshot from 2024-11-20 14-34-23

The server will continue running smoothly, and there is no file tampering or password leak.

@bichhawat Sir, Please review.

P.S. Please use the latest code and ensure all PRs are merged before running it.