search

IJHack / QtPass

QtPass is a multi-platform GUI for pass, the standard unix password manager.
https://qtpass.org/
GNU General Public License v3.0
1.03k stars 162 forks source link

Deleting empty dir fails via UI on Windows #441

Open christian-weiss opened 5 years ago

christian-weiss commented 5 years ago

Steps to reproduce:

1) enable git support 2) add dir via context menu 3) delete empty dir via context menu

Error message: fatal: pathspec 'E:/mypasswordstore/emptytestdir/' did not match any files.

After this error the empty dir is still existing. If i want to delete it i need to change my settings and disable git support for a moment to be able to delete that dir via UI.

As git is file oriented, empty dirs can not be committed nor deletion committed. Just skip the "git commit" step and do not trigger a git push (if auto push if maybe enabled).

Windows 10 64-bit QTpass 1.2.3 gpg2.exe: 2.0.26 (Gpg4win 2.2.2) git.exe: git version 2.18.0.windows.1

christian-weiss commented 5 years ago

Same error appears on ubuntu, too. But only if you use "Nativ git/gpg" option in Settings / Programs. With option "Use pass" this is working well.

christian-weiss commented 4 years ago

I re-checked this issue. Sadly still existing.

Same steps as above, but error message has changed:

Error: testbug; is not in the password store.

After this error the empty dir is still existing.

Looks like low hanging fruit - 14 month later, i am a bit surprised that this bug is still existing.

My environment: Windows 10 64-bit QtPass 1.3.2 gpg2.exe: 2.0.26 (Gpg4win 2.2.2) git.exe: git version 2.18.0.windows.1

annejan commented 4 years ago

It should indeed test for git (and not try to git delete empty folder, but do a normal delete).