maciejsszmigiero commented 5 years ago

Commit 990b89c0ee6231 ("Removed unused headers from mainwindow.cpp. Disable UseTrayIcon if it's not available for the OS.") moved Pass finishedShow() signal connection for a PasswordDialog from MainWindow::setPassword() to the (first) PasswordDialog constructor.

However PasswordDialog has actually two constructors, and the second one needs to make this connection, too, otherwise the "Edit password" function does not load the edited entry data.

See: https://github.com/IJHack/QtPass/issues/423 https://github.com/IJHack/QtPass/issues/465 https://github.com/IJHack/QtPass/issues/470

coveralls commented 5 years ago

Coverage decreased (-0.02%) to 6.95% when pulling b42dc5dcacc0cf07ab870032ad9652e6dc8b7d7b on maciejsszmigiero:passworddialog-finishedshow-fix into 87217d3be810320cbaf3fa0b1bd22ca29f87c59b on IJHack:master.

codecov[bot] commented 5 years ago

Codecov Report

Merging #473 into master will decrease coverage by <.01%. The diff coverage is 0%.

@@            Coverage Diff            @@
##           master    #473      +/-   ##
=========================================
- Coverage    7.33%   7.32%   -0.01%     
=========================================
  Files          44      44              
  Lines        2796    2798       +2     
=========================================
  Hits          205     205              
- Misses       2591    2593       +2

Impacted Files	Coverage Δ
src/passworddialog.cpp	`58.09% <0%> (-1.13%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 87217d3...b42dc5d. Read the comment docs.

IJHack / QtPass

Add missing finishedShow() signal connection in PasswordDialog constructor (fixes the "Edit password" function) #473

Codecov Report