search

IKANOW / Aleph2

The IKANOW v2 meta-database and analytics platform
Apache License 2.0
2 stars 1 forks source link

Aleph 83 security fixes #75

Closed jfreydank closed 8 years ago

jfreydank commented 8 years ago

Fixes for security multi-threading

Alex-Ikanow commented 8 years ago

All looks good to me in terms of API

Joern, anything particular I should be looking out for in the implementation (apart from the JVM stuff we discussed) eg any remaining worries you have about how it might be used/abused in akka or anything like that?

jfreydank commented 8 years ago

So the only outstanding issue that I can think of is that shiro's ThreadContext used an internal thread safe map where they have a special case implemented dealing with parent-child threads. This resolves some bugs/issues that I don't fully understand. We just have to be aware that there could be something potentially critical going on for parent-child threads. However, it might just be something we have not come across yet and shiro fixed it already for us. I think akka uses parent-child threads, so we will see. On Mar 8, 2016 5:12 PM, "Alex" notifications@github.com wrote:

All looks good to me in terms of API

Joern, anything particular I should be looking out for in the implementation (apart from the JVM stuff we discussed) eg any remaining worries you have about how it might be used/abused in akka or anything like that?

— Reply to this email directly or view it on GitHub https://github.com/IKANOW/Aleph2/pull/75#issuecomment-194012189.