IMAP-Science-Operations-Center / imap_processing

IMAP

MIT License

6 stars 16 forks source link

SWE: calculate phase space density #1041

Closed tech3371 closed 4 weeks ago

tech3371 commented 1 month ago

Change Summary

closes #884

Overview

Function to calculate SWE L2 phase space density. I used lot of ideas Greg suggested before leave.

Updated Files

imap_processing/swe/l1b/swe_l1b_science.py
- update caused from refactor code
imap_processing/swe/l2/swe_l2.py
- main changes to calculate phase space density
imap_processing/swe/utils/swe_utils.py
- refactor way of reading in lookup table

Testing

imap_processing/tests/swe/test_swe_l2.py
- added test for new function

tech3371 commented 4 weeks ago

LGTM, although I'm not super familiar with the rest of the code base. I appreciate the use of dataframes rather than dicts.

Thank you for quick review. I know you just go back.

dataframes ideas credit goes to Greg. I was not happy with what I had before and asked Greg for ideas. He was the one who suggested getting everything in same shape to simplify mathematical operations.