search

IMB11 / Fog

A total overhaul of Minecraft's fog, offering options to customize fog color, start, and end points. Enjoy a more immersive experience with enhanced depth and visuals, all while keeping the same view distance.
https://modrinth.com/mod/fog
Other
27 stars 7 forks source link

No option to disable nighttime fog colors (nighttime fog colors are too bright) #37

Closed 22luminary closed 1 month ago

22luminary commented 1 month ago

There should be an option to disable fog switching colors at night. I think this mod looks amazing but the blue fog at night bothers me too much!

minhty-fresh commented 1 month ago

Agreed! I love the daytime and rain fog, but the I'd like my nights to be very dark.

Steveplays28 commented 1 month ago

Hi,I think the issue is that your fog definitions are out-of-date. We fixed the nighttime fog colors a while back, but our update screen doesn't have an option to auto-update the fog colors yet. IMB wants to work on this in the near future.

Could you please update your fog definitions, by deleting them and letting Fog recreate them (located at config/fog/fog_definitions)?

Most nighttime fog colors that I tested are dark, as they should be. I just fixed the badlands nighttime fog colors as well, that was the only one that stood out to me as being too bright at night. Feel free to reopen the issue if there are any nighttime fog colors that look too bright to you.

Thanks for checking out Fog!

Steveplays28 commented 1 month ago

I've also reduced the brightness the beach and default nighttime fog colors. Beaches are now almost pitch black and the default is now fully pitch black.

minhty-fresh commented 1 month ago

Thank you for your work on this! I think the issue seems to be that config/fog/fog_definitions doesn't update, even when that folder or the entire config/fog folder is deleted. I just tried doing both and both times the fog update menu came up when I restarted Minecraft, but the fog definitions folder only contains pack.mcmeta and README.txt, nothing else.

image

I also just tested from a complete brand new install of Minecraft on Modrinth with just Fog installed and on very first startup, the fog_definitions folder doesn't have anything besides those two files. Deleting the folders again also still had the same result.

Here's the config folder and the logs if it'd be helpful for debugging config.zip 2024-10-18-2.log.gz

Steveplays28 commented 1 month ago

Yeah that's also an issue currently @mdaole, see #39, though it means that the fog definitions from the JAR will always be used, since there aren't any unpacked files to load instead. IMB is going to take a look at this in the near future.

Steveplays28 commented 1 month ago

The changes I mentioned have been released in Fog v1.5.0.

minhty-fresh commented 1 month ago

Love it, thank you