search

INN / umbrella-cpipr

umbrella repository for Centro de Periodismo Investigativo
http://periodismoinvestigativo.com
GNU General Public License v2.0
1 stars 5 forks source link

Improvements #39

Closed rocaiguina closed 4 years ago

rocaiguina commented 4 years ago

Changes

This pull request makes the following changes:

Why

For #

Testing/Questions

Features that this PR affects:

Questions that need to be answered before merging:

Steps to test this PR:

Additional information

INN Member/Labs Client requesting: (if applicable)

benlk commented 4 years ago

Your staging site is http://staging.agile-engine.flywheelsites.com/ , and it appears to have been last updated around September 2019.

When we deploy this PR to your staging site, do you want us to also copy your production site's database, plugins, and uploads to the staging site?

rocaiguina commented 4 years ago

Sorry for the delay, yes please update the staging site and branch. Thanks @benlk

rocaiguina commented 4 years ago

Hi @benlk, Updated the template description. Let me know if there is anything else we should fix. Thanks

benlk commented 4 years ago

Hi @rocaiguina

When Flywheel copied prod to staging earlier, it appears that that copy process was incomplete. We're recopying production to staging now, and will deploy these latest changes when the copy is done.

benlk commented 4 years ago

No update from Flywheel at this time.

rocaiguina commented 4 years ago

Hello Ben, Hope all is well. I deactivated Fastest Cache as Flywheel support asked. Did you guys try deploying to staging again without success after that?

On Wed, Jun 3, 2020 at 8:10 PM Ben Keith notifications@github.com wrote:

No update from Flywheel at this time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/INN/umbrella-cpipr/pull/39#issuecomment-638524589, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAY5SGWVUNPJ43P4MHGYPZTRU3Q6ZANCNFSM4NOYN42Q .

benlk commented 4 years ago

@rocaiguina I saw the new commits; is this ready for us to take another look at it?

rocaiguina commented 4 years ago

hi @benlk, Not yet, hopefully later today. Thanks for keeping an eye out.

rocaiguina commented 4 years ago

@benlk please check the latest commits by @jmoreira-linkux and let us know if they solve the issues

benlk commented 4 years ago

@rocaiguina

The only thing not addressed is https://github.com/INN/umbrella-cpipr/pull/39#discussion_r437844358 , but I haven't noticed it come up in my testing.

We've redeployed to your staging site at http://staging.agile-engine.flywheelsites.com/ so you can check the site.

If you're ready, we can deploy this to production on Monday.

rocaiguina commented 4 years ago

Hi @benlk, Please deploy the latest changes to staging. If everything is ok after UAT, I think we will be good to go. Thanks, Luis

benlk commented 4 years ago

We've deployed it to your staging site! http://staging.agile-engine.flywheelsites.com/

Please let us know when you want us to deploy to your live site, or if you'll be doing that.

rocaiguina commented 4 years ago

awesome, thanks @benlk !

rocaiguina commented 4 years ago

hey @benlk , We uploaded some .mo and .po files in commit 20ebcd1c. These are for translations to the give and give-recurring plugins Please check if they were uploaded. The translation aren't working in staging. Thanks, Luis

benlk commented 4 years ago

My bad; I had not uploaded those. I have uploaded them now.

rocaiguina commented 4 years ago

He @benlk , For some reason this form is not being translated http://staging.agile-engine.flywheelsites.com/donaciones/ Locally it is working, any idea why this could be happening?

rocaiguina commented 4 years ago

Nevermind, it's working now. Thanks