Dev - refactoring, retain cycle broken, timer invalidated - Githubissues

INPS-it / SPIDlibraryIOS

SPIDlibraryIOS is a library for logging in via SPID through several different identity providers.

BSD 3-Clause "New" or "Revised" License

52 stars 5 forks source link

Dev - refactoring, retain cycle broken, timer invalidated #1

Closed mrcfal closed 3 years ago

mrcfal commented 3 years ago

👋

What?

Two changes:

Broken retain cycle when using strong reference on SpidDelegate;
Invalidated timer when tapping on dismiss button in LoginVC;

Few refactoring changes (feel free to edit or discard them, edits by maintainers are on):

Refactored checkError() function in ErrorManager by adding tryError() throws private function;
Refactored enums by removing unnecessary explicit raw values (strings);
Replaced protocol keyword class with AnyObject (class will be deprecated);

Testing?

Ran checkError() tests

Anything Else?

Suggestions:

moving the ErrorManager tests in a different test file
some tests fail by design, maybe you want to refactor them to pass by design, or at least make it clear which ones are the ones that have to fail (i.e. using some naming conventions);