search

IQSS / Zelig

A statistical framework that serves as a common interface to a large range of models
http://zeligproject.org
111 stars 43 forks source link

Arima doc #298

Closed mbsabath closed 7 years ago

mbsabath commented 7 years ago

The setx and setx1 methods both need to be called in order to successfully plot the results of time series models. Previously this was not documented. I added a line to the Arima vignette so this would be clear.

christophergandrud commented 7 years ago

Thanks @mbsabath

Can you split off https://github.com/IQSS/Zelig/pull/298/commits/301a2547460b79d3130356a6357b01e64003147cand make a pull request with just this?

The setx issue I think needs more work, discussed over at https://github.com/IQSS/Zelig/issues/299

mbsabath commented 7 years ago

I can do that, although this branch consists only of documentation changes to this file, so my thoughts on the matter are that it would make sense to merge both of these changes in at once, rather than separately.

christophergandrud commented 7 years ago

My thinking is that we don't really need to hold up the deployment of one document change while we solve an unrelated bug. (I'ld rather not create documentation for a bug, but solve the bug.)

mbsabath commented 7 years ago

Reasonable, I thought you wanted to hold off on updating the arima doc with the general information in the first commit until the bug was fixed.